 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH 1 of 5] xentrace: fix t_info_pages calculation fo
| To: | Keir Fraser <keir.xen@xxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH 1 of 5] xentrace: fix t_info_pages calculation for the default case |
| From: | Olaf Hering <olaf@xxxxxxxxx> |
| Date: | Wed, 23 Mar 2011 12:20:40 +0100 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx> |
| Delivery-date: | Wed, 23 Mar 2011 04:21:21 -0700 |
| Dkim-signature: | v=1; a=rsa-sha1; c=relaxed/relaxed; t=1300879244; l=727; s=domk; d=aepfle.de; h=In-Reply-To:Content-Type:MIME-Version:References:Subject:Cc:To:From: Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=AoKNFeJWQOO4SKhqvt/tGEdC/0s=; b=Bck8wtiTGh2X93FzclztUkhiotaRdd0MKUXMfTC4Abex0cWf2GJ0A5U6fiPSzkjxcsQ 53i8XRCnTTaaeVNNb3TwkZcJ+MZ8Uq9O9uwIGHgFP+amQafYibH15WqajwUd4Hp5VzokE o3KJNpduAD0smwHh0z9laY2J9KK8UdbERSk= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <C9AF7A58.15475%keir.xen@xxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <4D89D5920200007800037DBE@xxxxxxxxxxxxxxxxxx> <C9AF7A58.15475%keir.xen@xxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Wed, Mar 23, Keir Fraser wrote: > On 23/03/2011 10:12, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote: > > >> t_info_pages /= PAGE_SIZE; > >> - if ( t_info_pages % PAGE_SIZE ) > >> + if ( t_info_pages % PAGE_SIZE || t_info_pages == 0 ) > > > > While certainly not having a significant effect, to the unsuspecting > > reader this looks like a bug - is it really meant to be a remainder > > operation on the *result* of a division (rather than on the original > > dividend)? Couldn't you just (ab)use PFN_UP() here? > > By which you mean to replace the division and subsequent if statement with > t_info_pages = PFN_UP(t_info_pages). I did not know about PFN_UP() until now, using it would work as well. Olaf _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| Previous by Date: | Re: [Xen-devel] [PATCH 5 of 5] xentrace: use consistent printk prefix, Olaf Hering |
|---|---|
| Next by Date: | [Xen-devel] Re: [Qemu-devel] [PATCH V11 06/15] xen: Add the Xen platform pci device, Alexander Graf |
| Previous by Thread: | Re: [Xen-devel] [PATCH 1 of 5] xentrace: fix t_info_pages calculation for the default case, Keir Fraser |
| Next by Thread: | Re: [Xen-devel] [PATCH 1 of 5] xentrace: fix t_info_pages calculation for the default case, Keir Fraser |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
