This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [RFC] x86: possible problem with guest_walk_tables()

At 14:19 +0000 on 21 Mar (1300717156), Jan Beulich wrote:
> >> Leaving aside the non-PAE case, does the fix presented look
> >> reasonable?
> >  
> > Yes, it looks correct to me.  Give me a Signed-off-by and I'll apply it. 
> Going with the page-fault-less case then for non-PAE? If we want
> that case to produce reserved bit faults too, I admit I'd prefer to
> submit a complete patch (which is half the reason why this was an
> RFC, non-signed-off one)... If we want no fault there, I'd like to
> comment that way in the code (so the or-ing with zero won't
> prompt later readers to wonder whether this isn't a bug/oversight).

OK, I'll wait until I can fix up the non-PAE case too.


Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, Xen Platform Team
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

Xen-devel mailing list