[Xen-devel] Re: serial console driver using release_irq()/setup_

To:	Jan Beulich <JBeulich@xxxxxxxxxx>
Subject:	[Xen-devel] Re: serial console driver using release_irq()/setup_irq() on suspend/resume
From:	Keir Fraser <keir.xen@xxxxxxxxx>
Date:	Thu, 17 Mar 2011 17:01:25 +0000
Cc:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date:	Thu, 17 Mar 2011 10:02:24 -0700
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:user-agent:date:subject:from:to:cc:message-id :thread-topic:thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=AM/SJiW6VFFOYfE/rFtwfssRqSpW4ANEB5MuaQJGgg4=; b=o/FqG7PwBlwmBqbZoG84R3gD6gLs49LmqEmZBZj0Kc6Zi2Vjxd82Lu/sbQ1WPpdvLf UoJ9hdIeIlFFmbK0ZgG3b1BwDoAD9Ik3dG646+RtuAqU98mW9Q7g9xnyIcN02tcPnLKu MqZYRtGjBeZgW5Z0+uOYb8/5mYPagoA3avqio=
Domainkey-signature:	a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=YCzVpdoZIFzQ+oUlTYTQefXjV4TG07xb4wX/enPdx/T64yLkXTd8n4J0SKobp+qKWE EusK6WB2Rqc9SI840Npzt3ECPbcMgSyV1g0banX0LkT7vig5+b/JyMdGjtGQLlOm39jw o9r36SNW40Ydgyrfu5F4cQn3GBqqhL/pG1Ftk=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<4D8248D3020000780003720C@xxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AcvkxPLkyJWr6ZUCGEabvgue2TMn6A==
Thread-topic:	serial console driver using release_irq()/setup_irq() on suspend/resume
User-agent:	Microsoft-Entourage/12.28.0.101117

On 17/03/2011 16:45, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

> Keir,
> 
> is there any particular reason this is being done this way, other than
> having made the change in 15259:35e38c9048c8 very simple? I'm
> asking because in general, with no modules, Xen ought to not need
> setup_irq() post-init (for release_irq() the serial driver is actually the
> only consumer), and after fiddling with request_irq() callers this is
> now the only one needing the function to be in .text.

I expect it was done that way for simplicity, so that resume looks like
boot-time init. Feel free to mess with it and make a more customised
streamlined resume path.

 -- Keir

> Jan
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

[Xen-devel] Re: serial console driver using release_irq()/setup_irq() on