This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] ept: Fix bug in changeset 22526:7a5ee3800417

To: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] ept: Fix bug in changeset 22526:7a5ee3800417
From: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Date: Wed, 16 Mar 2011 09:40:15 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 16 Mar 2011 02:41:38 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <56b32e6fd3158e34288e.1300203711@elijah>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <56b32e6fd3158e34288e.1300203711@elijah>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-06-14)
At 15:41 +0000 on 15 Mar (1300203711), George Dunlap wrote:
> This fixes a bug in changeset 22526:7a5ee3800417, where the wrong
> value is read when deciding whether to flush the VTd tables.  The
> effect is minor: in situations where the p2m entry is changed but the
> mfn is the same, the VTd tables will be unnecessarily flushed.
> old_entry is left untouched in the second case, since having a present
> old_entry will cause the an unnecessary check to be taken at the end
> of the function.
> Spotted-by: Zhang, Peng Fei <zpfalpc23@xxxxxxxxx>
> Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

Applied, thanks.


Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, Xen Platform Team
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

Xen-devel mailing list