This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [GIT/PATCH v5] xen network backend driver

To: David Miller <davem@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [GIT/PATCH v5] xen network backend driver
From: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Date: Tue, 15 Mar 2011 07:09:36 +0000
Cc: "jeremy@xxxxxxxx" <jeremy@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "herbert@xxxxxxxxxxxxxxxxxxx" <herbert@xxxxxxxxxxxxxxxxxxx>, "konrad.wilk@xxxxxxxxxx" <konrad.wilk@xxxxxxxxxx>, "netdev@xxxxxxxxxxxxxxx" <netdev@xxxxxxxxxxxxxxx>, "mirqus@xxxxxxxxx" <mirqus@xxxxxxxxx>, "romieu@xxxxxxxxxxxxx" <romieu@xxxxxxxxxxxxx>, "bhutchings@xxxxxxxxxxxxxx" <bhutchings@xxxxxxxxxxxxxx>, "shemminger@xxxxxxxxxx" <shemminger@xxxxxxxxxx>
Delivery-date: Tue, 15 Mar 2011 00:10:22 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20110314.152255.68135182.davem@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <1300131040.32696.23.camel@xxxxxxxxxxxxxxxxxxxxx> <20110314.132355.226777213.davem@xxxxxxxxxxxxx> <1300141060.32696.36.camel@xxxxxxxxxxxxxxxxxxxxx> <20110314.152255.68135182.davem@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Mon, 2011-03-14 at 22:22 +0000, David Miller wrote:
> From: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
> Date: Mon, 14 Mar 2011 22:17:40 +0000
> > Would you consider a commit patch which imports the baseline driver as
> > is from xen.git (this builds and is functional but needed clean up)
> > followed by the cleanup series? I made sure the cleanup part builds and
> > works at each step as I went (but I will run through it again to be
> > sure).
> > 
> > There is real value (to me at least) in keeping the cleanup separate and
> > being able to (even manually) associate the first upstream commit with
> > an equivalent point in the historical code.
> Do you have any idea what that thing is going to do for poor souls trying
> to bisect?
> GIT is going to hop in and out of your line of development for any GIT
> bisect that traverses any period of time in which those driver commits
> exists.
> It's too messy.

It's exactly the same as any other patch series in this respect though,
isn't it?

But... I'd forgotten that up until "xen: netback: Make dependency on
PageForeign conditional" I was running with a local non-upstreamable
branch containing the PageForeign infrastructure merged which I removed
once I removed the PageForeign dependency was gone, so the series isn't
actually fully buildable upstream like I thought.

So I'll resend a single patch version of the driver today.

> You can keep your tree online somewhere to publish the history, just
> like we do for the old bitkeeper import and similar.



Xen-devel mailing list