This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 3/12] VTPM mini-os: Add ioread() and iowrite() fu

To: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 3/12] VTPM mini-os: Add ioread() and iowrite() functions to mini-os
From: Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>
Date: Mon, 14 Mar 2011 13:10:54 -0400
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 14 Mar 2011 10:16:31 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20110312002914.GD4922@xxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4D7AA468.7000204@xxxxxxxxxx> <20110312002914.GD4922@xxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20101208 Thunderbird/3.1.7
Yeah your right, sorry about that! Heres a patch that applies on top of the previous one to add volatile.

Signed off by: Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>

On 03/11/2011 07:29 PM, Samuel Thibault wrote:
Matthew Fioravante, le Fri 11 Mar 2011 17:38:32 -0500, a écrit :
Mini-os currently doesn't have very many facilities for reading and
writing to hardware io memory. This patch addes  a new header file
iorw.h which when included gives access to
the ioread8(), iread32(), iowrite8(), iowrite32() family of functions.

+void iowrite8(void* addr, uint8_t val)
+   *((uint8_t*)addr) = val;
+void iowrite32(void* addr, uint32_t val)
+   *((uint32_t*)addr) = val;
Don't you need a volatile qualifier on the cast pointer to not let the
compiler optimize it away?


Attachment: 3-minios-iorw.patch2
Description: Text document

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

Xen-devel mailing list