xen-devel

[Top] [All Lists]

[Xen-devel] [PATCH 1/3] _csched_cpu_pick(): don't return CPUs outside vC

from [Jan Beulich]

[Permanent Link][Original]

To:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	[Xen-devel] [PATCH 1/3] _csched_cpu_pick(): don't return CPUs outside vCPU's affinity mask
From:	"Jan Beulich" <JBeulich@xxxxxxxxxx>
Date:	Mon, 14 Mar 2011 17:04:18 +0000
Delivery-date:	Mon, 14 Mar 2011 10:12:16 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

This fixes a fairly blatant bug I introduced in c/s 20377:cff23354d026
- I wonder how this went unnoticed for so long.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

--- a/xen/common/sched_credit.c
+++ b/xen/common/sched_credit.c
@@ -530,6 +531,7 @@ _csched_cpu_pick(const struct scheduler 
              || ( !sched_smt_power_savings
                   && (weight_cpu * migrate_factor < weight_nxt) ) )
         {
+            cpus_and(nxt_idlers, cpus, nxt_idlers);
             cpu = cycle_cpu(CSCHED_PCPU(nxt)->idle_bias, nxt_idlers);
             if ( commit )
                CSCHED_PCPU(nxt)->idle_bias = cpu;

csched-pick-fix.patch
Description: Text document

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH 1/3] _csched_cpu_pick(): don't return CPUs outside vCPU's affinity mask, Jan Beulich <=

Previous by Date:	Re: [Xen-devel] [PATCH 4/12] VTPM mini-os: Mini-os machine specific headers, Matthew Fioravante
Next by Date:	[Xen-devel] [PATCH 2/3] _csched_cpu_pick(): don't write idle bias more than once, Jan Beulich
Previous by Thread:	[Xen-devel] [PATCH 0/3] csched: adjustments to _csched_cpu_pick(), Jan Beulich
Next by Thread:	[Xen-devel] [PATCH 2/3] _csched_cpu_pick(): don't write idle bias more than once, Jan Beulich
Indexes:	[Date] [Thread] [Top] [All Lists]