This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] RE: [PATCH 4/4] x86/HPET: adjust types

To: Jan Beulich <JBeulich@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] RE: [PATCH 4/4] x86/HPET: adjust types
From: "Wei, Gang" <gang.wei@xxxxxxxxx>
Date: Sat, 12 Mar 2011 19:16:24 +0800
Accept-language: zh-CN, en-US
Acceptlanguage: zh-CN, en-US
Cc: "Wei, Gang" <gang.wei@xxxxxxxxx>
Delivery-date: Sat, 12 Mar 2011 03:17:06 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D7A4F420200007800035EBC@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4D7A4F420200007800035EBC@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcvgAc56dhOTWgTnQS23ypFSbjfvZwApQlGw
Thread-topic: [PATCH 4/4] x86/HPET: adjust types
Jan Beulich wrote on 2011-03-11:
> 'unsigned int' is better suited as an array index on x86-64.
> 'u32' produces better code than 'unsigned long' on x86-64, so use the 
> former for storing 32-bit values read from the hardware.
> this_cpu() uses an implicit smp_processor_id(), and hence using
> per_cpu() when the result of smp_processor_id() is already available 
> is more efficient.
> Fold one case of cpu_isset()+cpu_clear() into cpu_test_and_clear().
> Drop the unused return value of evt_do_broadcast().
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

Acked-by: Wei Gang <gang.wei@xxxxxxxxx>


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>