WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 0/12] VTPM mini-os: TPM device drivers for mini-o

To: Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 0/12] VTPM mini-os: TPM device drivers for mini-os
From: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
Date: Sat, 12 Mar 2011 01:37:05 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 11 Mar 2011 17:43:22 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D7AA743.5030703@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>, Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
References: <4D7AA743.5030703@xxxxxxxxxx>
Resent-date: Sat, 12 Mar 2011 02:39:55 +0100
Resent-from: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
Resent-message-id: <20110312013955.GL4922@xxxxxxxxxxxxxxxxxxxxxxxxx>
Resent-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.12-2006-07-14
Matthew Fioravante, le Fri 11 Mar 2011 17:50:43 -0500, a écrit :
> This patch adds 3 new drivers to mini-os
> 
> tpmfront: Paravirtualized tpm driver that can speak to mini-os tpmback 
> and linux tpmbk
> tpmback: Paravirtualized tpm backend driver that can speak to mini-os 
> tpmfront and linux tpm_xenu
> tpm_tis: Hardware tpm driver. Should work with any TPM device compliant 
> with the 1.2 spec. Requires io memory passthrough.
> 
> Signed off by: Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>

I don't have the time to review the driver code in details, but the
overall shape and interaction with the rest of mini-os looks good to me.

> @@ -177,6 +179,7 @@
>       } tap;
>       struct {
>           struct blkfront_dev *dev;
> +         off_t offset;
>       } blk;
>       struct {
>           struct kbdfront_dev *dev;

This seems like an unrelated change, right?

Samuel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>