| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
[Xen-devel] Re: [GIT/PATCH v4] xen network backend driver
|
To: |
Ian Campbell <Ian.Campbell@xxxxxxxxxx> |
|
Subject: |
[Xen-devel] Re: [GIT/PATCH v4] xen network backend driver |
|
From: |
Stephen Hemminger <shemminger@xxxxxxxxxx> |
|
Date: |
Thu, 10 Mar 2011 09:15:55 -0800 |
|
Cc: |
Jeremy Fitzhardinge <jeremy@xxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, "netdev@xxxxxxxxxxxxxxx" <netdev@xxxxxxxxxxxxxxx>, Francois Romieu <romieu@xxxxxxxxxxxxx>, Ben Hutchings <bhutchings@xxxxxxxxxxxxxx> |
|
Delivery-date: |
Fri, 11 Mar 2011 09:52:46 -0800 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<1299776554.17339.824.camel@xxxxxxxxxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
Organization: |
Vyatta |
|
References: |
<1299776554.17339.824.camel@xxxxxxxxxxxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On Thu, 10 Mar 2011 17:02:33 +0000
Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> +struct xenvif {
> + /* Unique identifier for this interface. */
...
> + struct net_device_stats stats;
> +
There is already a stats struct in net_device in current kernel
versions, unless there is a compelling reason otherwise
please use that.
Also, you probably want to implement per-cpu and 64 bit
stats.
--
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home