This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 03/10] blktap: Move from drivers/xen to drivers/b

On Thu, 2011-03-10 at 03:24 -0500, Ian Campbell wrote:

> > Oooh, scratch that, that's not even the case.
> > 
> > I seem to finally be getting what you're really talking about. This is
> > not really a broken commit, it's solely about send-email not enabling
> > rename *detection*. Interesting, I always assumed the renaming case must
> > be a property of the commit object, not a diff feature.
> I don't know if it is a feature of the commit metadata (which FWIW I'd
> expect to be retained over a rebase etc) or something which is computed
> at diff generation time. In any case -M is required to get the git patch
> syntax, the default is to be compatible with old-school patch utils.
> > That correct now?
> <1299715326-26236-1-git-send-email-daniel.stodden@xxxxxxxxxx> looks
> good.


I learned -M is actually a git-diff option passed through. The man page
mentions it's O(n^2).

I had to learn all that while wondering if there's a config option to
turn it on, and that took me O(n).

It's [diff] renames = true btw, but might be a bad idea.


> > 
> > Daniel
> >
> > 
> > 
> > 
> > 
> > 

Xen-devel mailing list