WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] bogus HPET initialization order on x86

To: Keir Fraser <keir.xen@xxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Wei, Gang" <gang.wei@xxxxxxxxx>
Subject: RE: [Xen-devel] bogus HPET initialization order on x86
From: "Yu, Ke" <ke.yu@xxxxxxxxx>
Date: Thu, 10 Mar 2011 09:24:16 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc:
Delivery-date: Wed, 09 Mar 2011 17:25:52 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C99D5752.1473F%keir.xen@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4D77A07D020000780003593A@xxxxxxxxxxxxxxxxxx> <C99D5752.1473F%keir.xen@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcvedLmAXfgN1GHc4kKh0kVZjTfGwAATHC/w
Thread-topic: [Xen-devel] bogus HPET initialization order on x86
CC the author Wei Gang 

Regards
Ke

> -----Original Message-----
> From: Keir Fraser [mailto:keir.xen@xxxxxxxxx]
> Sent: Thursday, March 10, 2011 12:12 AM
> To: Jan Beulich; xen-devel@xxxxxxxxxxxxxxxxxxx
> Cc: Yu, Ke
> Subject: Re: [Xen-devel] bogus HPET initialization order on x86
> 
> On 09/03/2011 14:45, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:
> 
> >> From looking at the code I cannot deduce why it wouldn't be possible
> > for hpet_interrupt_handler() or hpet_legacy_irq_tick() to be called
> > while hpet_broadcast_init() is still executing. If that's indeed
> > possible, then the setting of .event_handler clearly has to happen
> > *after* initializing the channel's spinlock and rwlock.
> >
> > Further, with the channel getting enabled (down the
> > hpet_fsb_cap_lookup() call tree) before hpet_events[] gets fully
> > initialized, I'd also think it should be possible to hit the spurious
> > warning in hpet_interrupt_handler() just because of improper
> > initialization order.
> >
> > If that's all impossible in practice, adding some meaningful comments
> > to the code to describe why this is so would be much appreciated.
> 
> Only someone at Intel could answer these questions. Cc'ing Yu Ke, who seems
> most involved in this aspect.
> 
>  -- Keir
> 
> > Thanks, Jan
> >
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@xxxxxxxxxxxxxxxxxxx
> > http://lists.xensource.com/xen-devel
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel