This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] bogus check in get_page_from_l1e()?

To: "Keir Fraser" <keir@xxxxxxx>
Subject: [Xen-devel] bogus check in get_page_from_l1e()?
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Tue, 08 Mar 2011 11:07:41 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 08 Mar 2011 03:08:26 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

in the I/O page code path, we have

        if ( !iomem_access_permitted(pg_owner, mfn, mfn) )
            if ( mfn != (PADDR_MASK >> PAGE_SHIFT) ) /* INVALID_MFN? */
                MEM_LOG("Non-privileged (%u) attempt to map I/O space %08lx", 
                        pg_owner->domain_id, mfn);
            return 0;

What is the reason to suppress the warning for the one specific
(PADDR_MASK >> PAGE_SHIFT) MFN value, i.e. where could this
validly come from and hence warrant not to issue the warning?

Also, the message seems to be having the potential of being
misleading (these days at least, but perhaps it always was), as
it clearly is possible for Dom0 to also be denied a mapping here
(and hence the "Non-privileged" can be wrong).

Bottom line question: Should we issue the warning unconditionally,
just stating the domain ID?

Thanks, Jan

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>