This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH] pvops: Resume devices when suspend is failed

To: Frank Pan <frankpzh@xxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] pvops: Resume devices when suspend is failed
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Mon, 7 Mar 2011 17:22:34 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>, Jeremy Fitzhardinge <Jeremy.Fitzhardinge@xxxxxxxxxx>, Stefano
Delivery-date: Mon, 07 Mar 2011 09:23:34 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <AANLkTinXnNK+75Nye713q5jzuXAd3+2iwvZSJBgfiiFi@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <AANLkTinXnNK+75Nye713q5jzuXAd3+2iwvZSJBgfiiFi@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Fri, 4 Mar 2011, Frank Pan wrote:
> Recent pvops kernel does not call dpm_resume_end when
> dpm_suspend_start is failed. This makes some device remain suspended
> after the unsuccessful call of do_suspend from xenbus.
> In my test, a PV-on-HVM guest printed the following message after
> received a suspend request through xenbus, and then stucked due to
> disk access.
> [41577.764748] sd 0:0:0:0: [sda] Stopping disk
> [41577.765273] PM: Device input2 failed to suspend: error -22
> [41577.765275] xen suspend: dpm_suspend_start -22
> The following patch fixes this by calling dpm_suspend_start after the
> failure of dpm_resume_end.

Thanks for spotting this issue and for the patch!
However I think it would be better to move out_thaw before
dpm_resume_end instead.
Would you be OK to do that and send a patch?

Xen-devel mailing list