[Xen-devel] Re: [PATCH] pvops: Resume devices when suspend is failed

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 4 Mar 2011, Frank Pan wrote:
> Recent pvops kernel does not call dpm_resume_end when
> dpm_suspend_start is failed. This makes some device remain suspended
> after the unsuccessful call of do_suspend from xenbus.
> 
> In my test, a PV-on-HVM guest printed the following message after
> received a suspend request through xenbus, and then stucked due to
> disk access.
> 
> [41577.764748] sd 0:0:0:0: [sda] Stopping disk
> [41577.765273] PM: Device input2 failed to suspend: error -22
> [41577.765275] xen suspend: dpm_suspend_start -22
> 
> The following patch fixes this by calling dpm_suspend_start after the
> failure of dpm_resume_end.

Thanks for spotting this issue and for the patch!
However I think it would be better to move out_thaw before
dpm_resume_end instead.
Would you be OK to do that and send a patch?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel