This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH pvops] Fix a bug that shutdown watcher is disable

To: Frank Pan <frankpzh@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH pvops] Fix a bug that shutdown watcher is disabled on pvops
From: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Date: Fri, 4 Mar 2011 08:41:30 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>, Jeremy Fitzhardinge <Jeremy.Fitzhardinge@xxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Delivery-date: Fri, 04 Mar 2011 00:42:40 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <AANLkTi=xQ6xQJmbUphGjcGEMwKmS6kuorL3oDPpSVPm7@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <AANLkTikUyYpVKG_LZHFLL-ziCfU-Oc3qM9uFCd7QH13Z@xxxxxxxxxxxxxx> <20110303182909.GA10812@xxxxxxxxxxxx> <AANLkTi=xQ6xQJmbUphGjcGEMwKmS6kuorL3oDPpSVPm7@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, 2011-03-04 at 02:09 +0000, Frank Pan wrote:
> Sorry I didn't mention it. I use jeremy's tree.
> git clone git://git.kernel.org/pub/scm/linux/kernel/git/jeremy/xen.git
> linux-2.6-xen
> The kernel version is

Is the issue you are seeing perhaps due to this patch being missing from
that tree?

commit a947f0f8f7012a5e8689a9cff7209ec6964ec154
Author: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date:   Mon Oct 4 16:10:06 2010 +0100

    xen: do not set xenstored_ready before xenbus_probe on hvm
    Register_xenstore_notifier should guarantee that the caller gets
    notified even if xenstore is already up.
    Therefore we revert "do not notify callers from
    register_xenstore_notifier" and set xenstored_read at the right time for
    PV on HVM guests too.
    In fact in case of PV on HVM guests xenstored is ready only after the
    platform pci driver has completed the initialization, so do not set
    xenstored_ready before the call to xenbus_probe().
    This patch fixes a shutdown_event watcher registration bug that causes
    "xm shutdown" not to work properly.
    Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
    Acked-by: Jeremy Fitzhardinge <jeremy@xxxxxxxx>

If possible we should prefer to backport patches from newer kernels
rather than diverge in the 2.6.32 branch.

Stefano's "2.6.38-rc6-pvhvm" branch also contains this which looks

commit 702d4eb9b3de4398ab99cf0a4e799e552c7ab756
Author: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date:   Thu Dec 2 17:54:50 2010 +0000

    xen: no need to delay xen_setup_shutdown_event for hvm guests anymore
    Now that xenstore_ready is used correctly for PV on HVM guests too, we
    don't need to delay the initialization of xen_setup_shutdown_event
    Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
    Acked-by: Jeremy Fitzhardinge <jeremy@xxxxxxxx>


Xen-devel mailing list