This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] RE: main_pcilist_assignable

On Wed, 2 Mar 2011, Kay, Allen M wrote:
> Stefano,
> I found libxl missing many of the checking we had in xm python code when we 
> passthrough pci devices to the guest.
> Attached patch makes sure the passthrough device belongs to pciback before 
> allow them passthrough to the guest.  There are still many other checks 
> missing.

Thanks for the patch!

> Xm terminates the guest startup process when this type of condition is found. 
>  This patch just allows the guest to continue to boot but with no device 
> passthrough.  I tried to call exit() by the guest windows still hangs around. 
>  Is there an example code for calling exit that also closes the guest (QEMU 
> VGA) window?

libxl__device_pci_add needs to propagate the error to the callers and the
callers (do_domain_create and pciattach) need to handle it correctly.
In particular do_domain_create would have to goto error_out.

Xen-devel mailing list