This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] RE: TODO in windows balloon driver

To: "tinnycloud" <tinnycloud@xxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] RE: TODO in windows balloon driver
From: "James Harper" <james.harper@xxxxxxxxxxxxxxxx>
Date: Sat, 26 Feb 2011 23:17:54 +1100
Delivery-date: Sat, 26 Feb 2011 04:19:04 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <BLU157-ds12B8CAE5490173D7A39E59DADD0@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <SNT0-MC4-F15TlpsWqi0002f5ac@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <BLU157-ds1AEAC80753959EC959A12DA160@xxxxxxx> <291EDFCB1E9E224A99088639C47620228CF938AAE0@xxxxxxxxxxxxxxxxxxxxxxxxx> <AEC6C66638C05B468B556EA548C1A77D01BB8BA7@trantor> <BLU157-ds12B8CAE5490173D7A39E59DADD0@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcudjQT/1ru6fBA9Q+y8rx823coE9AACJPTwAAxzPMAAAQPzAA25IzBgAD+v1pA=
Thread-topic: TODO in windows balloon driver
> HI James:
>       I've noticed the TODO tag in xenpci/xenpci_fdo.c, line 294
>    290         KdPrint((__DRIVER_NAME "     Calling
> HYPERVISOR_memory_op(XENMEM_populate_physmap) - pfn_count = %d\n",
> pfn_count));
>    291         ret = HYPERVISOR_memory_op(xpdd,
> &reservation);
>    292         ExFreePoolWithTag(pfns, XENPCI_POOL_TAG);
>    293         KdPrint((__DRIVER_NAME "     populated %d pages\n",
>    294         /* TODO: what do we do if less than the required number
> pages were populated??? can this happen??? */
>       Could we fix it in linux balloon driver way?
>       When no enough pfn_count got, give memory back to xen.
>       What do you think?
>       Thanks.

I guess that would work, but then it would keep trying to decrease again
every second. Maybe that's what we want but I'd rather put in some sort
of backoff in there eg retry in one second then two seconds then 4
seconds etc up to a maximum of 1 minute or so, to reduce the noise.

Are you seeing this happen? I'm guessing it's because xen doesn't have
enough pages for you or because you've ballooned up above the maxmem
limit or something...


Xen-devel mailing list