 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] Avoid race when moving cpu between cpupools
| To: | Andre Przywara <andre.przywara@xxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] Avoid race when moving cpu between cpupools |
| From: | George Dunlap <George.Dunlap@xxxxxxxxxxxxx> |
| Date: | Thu, 24 Feb 2011 14:33:48 +0000 |
| Cc: | Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, "Diestelhorst, Stephan" <Stephan.Diestelhorst@xxxxxxx> |
| Delivery-date: | Thu, 24 Feb 2011 06:34:52 -0800 |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=eaBuLNDL7e+GQWZaODevfkepoHYu4f6NDFub2EsTN9w=; b=IadQUdkakBfY/+YGDhSZ8fUbWqYHmIDlNuiVoqyM06exUHZrtiZ7d5QcaX1AQuKJx1 sDwBZUbQ/I7aNTYucSX6ngU7Q5eiDz+rfe1jFAfcVLj/bN+gxDbVhEL/WH8fd+9FpgY7 RDCADn5AHHVM96068AOgVomsWoSHNGnWkBRSE= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=ZXlghjMM5+A6hxqqqu3apFsbVS9FJQDJjacZHRqMimCS0kc+MaKcnOl+YibzVuJAoK kZ/U9nUfdzIFotoKIY4RPmyGMNwq6lB/GrJmohqu1bU/yUb3SqthBXcljw1xyZKWy/qe HVJx1Z+9OJ6XHSmDDAicU/GhRljXBn+hcWxNg= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <4D666678.1000301@xxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <5485071c8b0a6a49f65b.1298541625@nehalem1> <4D666678.1000301@xxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
Looks good -- thanks Juergen. Acked-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx> -George On Thu, Feb 24, 2011 at 2:08 PM, Andre Przywara <andre.przywara@xxxxxxx> wrote: > Juergen Gross wrote: >> >> Moving cpus between cpupools is done under the schedule lock of the moved >> cpu. >> When checking a cpu being member of a cpupool this must be done with the >> lock >> of that cpu being held. > > I have reviewed and tested the patch. It fixes my problem. My script has > been running for several hundred iterations without any Xen crash, whereas > without the patch the hypervisor crashed mostly at the second iteration. > > Thanks Juergen and George for the persistent work! > >> Hot-unplugging of physical cpus might encounter the same problems, but >> this >> should happen only very rarely. >> >> Signed-off-by: juergen.gross@xxxxxxxxxxxxxx > > Acked-by: Andre Przywara <andre.przywara@xxxxxxx> > > Keir, please apply for 4.1.0. > > > Regards, > Andre. > > -- > Andre Przywara > AMD-Operating System Research Center (OSRC), Dresden, Germany > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@xxxxxxxxxxxxxxxxxxx > http://lists.xensource.com/xen-devel > _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] Xen 4 TSC problems, Olivier Hanesse |
|---|---|
| Next by Date: | [Xen-devel] [PATCH] tools: Handle failed xc_get_hvm_param in domain save, George Dunlap |
| Previous by Thread: | Re: [Xen-devel] [PATCH] Avoid race when moving cpu between cpupools, Andre Przywara |
| Next by Thread: | Re: [Xen-devel] [PATCH] Avoid race when moving cpu between cpupools, Andre Przywara |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
