WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH linux-2.6.18-xen] blktap: make max # of tap devi

To: Daniel Stodden <daniel.stodden@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH linux-2.6.18-xen] blktap: make max # of tap devices a module parameter
From: Laszlo Ersek <lersek@xxxxxxxxxx>
Date: Tue, 22 Feb 2011 19:08:11 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Delivery-date: Tue, 22 Feb 2011 10:07:58 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1298396687.27394.10.camel@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4D63C644.1000503@xxxxxxxxxx> <4D63E918020000780003327C@xxxxxxxxxxxxxxxxxx> <4D63F3B7.90108@xxxxxxxxxx> <1298396687.27394.10.camel@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.7
On 02/22/11 18:44, Daniel Stodden wrote:

> I'm pretty sure minors>  256 date way before 2.6.32. Here's the module
> init fragment from blktap2, replacing the register_chrdev() call:
> 
> [...]

That's about what I was thinking of in [0]. It also sets the cdev's owner 
manually. However, register_chrdev() also does this:

   225          kobject_set_name(&cdev->kobj, "%s", name);
   226          for (s = strchr(kobject_name(&cdev->kobj),'/'); s; s = 
strchr(s, '/'))
   227                  *s = '!';

I reckon we can ignore the 's,/,!,g' replacement, since the name is fixed 
"blktap" (or "blktap2"). But the kobject name doesn't appear to be set in the 
first place. Is that no problem? If not, I'd just omit it from blktap as well.

Thank you!
lacos

[0] https://bugzilla.redhat.com/show_bug.cgi?id=452650#c21

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel