WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [libvirt] [PATCH] libxenlight driver

To: Jim Fehlig <jfehlig@xxxxxxxxxx>
Subject: [Xen-devel] Re: [libvirt] [PATCH] libxenlight driver
From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Date: Mon, 21 Feb 2011 17:15:03 +0000
Cc: LibVir <libvir-list@xxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Markus Gross <gross@xxxxxxxxxxxxx>
Delivery-date: Mon, 21 Feb 2011 09:16:12 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D5DCB44.3060909@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4D5DCB44.3060909@xxxxxxxxxx>
Reply-to: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Feb 17, 2011 at 06:28:36PM -0700, Jim Fehlig wrote:
> Here's the latest version of a libxenlight driver for libvirt.
> 
> I've added a per-domain libxl_ctx in addition to the driver wide
> context.  The former is stored in virDomainObject privateData and used
> for operations on the domain.  The latter is stored in driver private
> data and is used for non-domain related libxl calls, e.g. getVersion,
> getNodeInfo, etc.  This approach was suggested by Ian Jackson and
> Stefano Stabellini and appears to be working much better than a single,
> driver wide libxl_ctx.  I no longer have the restart issues described in
> the first patch posting [1].
> 
> Your review and comments are much appreciated!

I've not had a chance todo a proper review yet, but after skimming
the patch I think your impl / architecture looks pretty good.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>