Re: [Xen-devel] [PATCH] Documentation: Include cpupool example i

André Przywara writes ("Re: [Xen-devel] [PATCH] Documentation: Include cpupool 
example in install"):
> Is this just a limit in the implementation or is the requirement for a 
> regular on-disk file there for a reason?

It's a limit in the implementation.  We try to read the config file
into a char array in memory, and that's most easily done by
stat/malloc/fread.

For a domain, the config file is used both immediately when creating
the domain (being parsed by being fed to the flex bytearray scanner
entrypoint) but also stored for use when the domain is migrated/saved.

> I could easily create a patch to do away with these restrictions (after 
> the release), are there any arguments against this?

No, that would be fine.  The right answer is probably somewhere around
libxl_read_file_contents.  Perhaps we need libxl_read_fd_contents
which reallocs.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:

RE: [Xen-devel] 2.6.32.27 dom0 + latest xen staging boot failure, Stefano Stabellini

Next by Date:

[Xen-devel] Re: [PATCH 1/2] xen: events: do not workaround too-small nr_irqs, Ian Campbell

Previous by Thread:

Re: [Xen-devel] [PATCH] Documentation: Include cpupool example in install, André Przywara

Next by Thread:

Re: [Xen-devel] [PATCH] Documentation: Include cpupool example in install, Ian Jackson

Indexes:

[Date] [Thread] [Top] [All Lists]