WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH v6] Userspace grant communication

To: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH v6] Userspace grant communication
From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Date: Mon, 14 Feb 2011 14:04:07 -0500
Cc: jeremy@xxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, Ian.Campbell@xxxxxxxxxx
Delivery-date: Mon, 14 Feb 2011 11:10:13 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D596C98.4090401@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1296753544-13323-1-git-send-email-dgdegra@xxxxxxxxxxxxx> <20110214161403.GB11034@xxxxxxxxxxxx> <4D596C98.4090401@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-06-14)
> > And besides the two questions I posted today they look OK to me. However
> > I have on question that I think points to a bug.

.. snip ..

> I think this will come out with map.index=4, op.index=8192, since the only
> entry in priv->maps has map->index = 0 and map->count = 4.

Duh! Yes, and that changes how this all works out.
..
> much simpler method of an always-incrementing index for generating offsets;
> there's no reason that that can't be done here if it looks like there's a
> mistake. The code does look correct to me, and I have tested it with 
> variable-size
> grants (although not in the 4/1/1 configuration you suggested).

That is OK. Thanks for working through this example.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel