WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 		  
Home Products Support Community News
 
   
 

xen-devel

[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [Xen-devel] [PATCH] qemu-xen: fix segfault with empty cdroms

from [Ian Jackson] [Permanent Link][Original]
To: Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] qemu-xen: fix segfault with empty cdroms
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Fri, 11 Feb 2011 17:54:19 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 11 Feb 2011 09:55:26 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <alpine.DEB.2.00.1102111747270.2826@kaball-desktop>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <alpine.DEB.2.00.1102111230350.2826@kaball-desktop> <19797.30125.552075.628420@xxxxxxxxxxxxxxxxxxxxxxxx> <alpine.DEB.2.00.1102111747270.2826@kaball-desktop>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx 
Stefano Stabellini writes ("Re: [Xen-devel] [PATCH] qemu-xen: fix segfault with 
empty cdroms"):
> No need, in fact if blkdev->params is NULL we return -1 right here.

Oh, yes, sorry, I misread the earlier thing as assigning to params.
I'll apply your patch.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [Xen-devel] [PATCH] libxl: do not call libxl__file_reference_unmap two times, Ian Jackson
Next by Date:  Re: [Xen-devel] [PATCH] libxl/xl: improve behaviour when guest fails to suspend itself, Ian Jackson
Previous by Thread:  Re: [Xen-devel] [PATCH] qemu-xen: fix segfault with empty cdroms, Stefano Stabellini
Next by Thread:  Re: [Xen-devel] [PATCH] libxc: lzma build fix, Jan Beulich
Indexes:  [Date] [Thread] [Top] [All Lists]
 
   

Copyright , Citrix Systems Inc. All rights reserved. Legal and Privacy