WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [xen-devel][PATCH 2/5] Xl interface change plus changes to code it i

To: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Subject: Re: [xen-devel][PATCH 2/5] Xl interface change plus changes to code it impacts
From: Kamala Narasimhan <kamala.narasimhan@xxxxxxxxx>
Date: Thu, 10 Feb 2011 09:37:55 -0500
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 10 Feb 2011 06:38:36 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=Y0aA7ob4p8X0jrmT+//pOxpZSD0s2PKNbSp+XQ8YbsA=; b=o+vURNfELGLxOSTRQtLE0xQFqTp/6YFDtBafYzssil4OjRcEQxDMS/UN6+KU3X3Y2i fgTEMnVxu0kvAoJq8MJbUlyMQQEE+M80XygscIm99rZctEeN5+JOx5EHq51V6ryug4Xu zNYnyTSTdg2aMnWaUat9aOHdU7hQ8BKCGRFts=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=x8nkToEx3S7VkPZeRqrStugC+lbpqIcLQJ4QMiGJgt+dxd21qM8mPSH+5vo9lOweUO ukjbpqP1PsnsM+IYDFz7l8trLv+RpAdjGGToI9nukJxiegAIiW5VuqSFFj/pT331cA0x d4AsxFYlhpMCJsg2+kWSqZnHgS70lAQMmfqtw=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1297328548.1047.38.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4D50628A.2000307@xxxxxxxxx> <1297175897.9388.114.camel@xxxxxxxxxxxxxxxxxxxxxx> <1297176074.9388.116.camel@xxxxxxxxxxxxxxxxxxxxxx> <4D518E7F.3020909@xxxxxxxxx> <1297328548.1047.38.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.24 (X11/20101027)
Ian Campbell wrote:
> On Tue, 2011-02-08 at 18:42 +0000, Kamala Narasimhan wrote:
>>>> Did we decide to leave DISK_BACKEND_DEFAULT (i.e. libxl chooses based on
>>>> the image type, host's backend support etc) for 4.2? I don't mind if we
>>>> did but does that make "block-dev-type" as described in patch 1/5
>>>> non-optional? (and therefore not really deprecated)
>>> Maybe this is handled in xl by patch 3/5?
>>>
>>> (I should really apply the patch and read the result instead of trying
>>> to decode the meaning from the patch form)
>>>
>> Yes, a fallback value is set in 3/5 but patch 5/5 will remove that fallback 
>> and
>> do appropriate validation to better handle this.
> 
> Patch 3/5 is all on the xl side though, right? I was meaning a default
> "do the right thing" at the libxl interface level, which given time
> might become the only option...
> 
> I didn't see a patch 5/5 what is in it?
> 
Based on further discussion we decided to go with patch 1 & 2 and a couple of
minor patches on top for 4.1 and apply the rest for 4.2.  I will send patch 5
along with 3 & 4 post 4.1.

Patch 5 is all validation code which will be pretty much in libxl and it will
take care of the fallback,  For now we do nothing more than what we already do 
IMO.

Kamala


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel