WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH 1/2] xen: events: do not workaround too-small nr_

To: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 1/2] xen: events: do not workaround too-small nr_irqs
From: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Date: Wed, 9 Feb 2011 16:57:11 +0000
Cc: Fitzhardinge <jeremy@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Jeremy
Delivery-date: Wed, 09 Feb 2011 08:58:19 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20110209162136.GA6160@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <1297249759.25616.16.camel@xxxxxxxxxxxxxxxxxxxxxx> <1297249845-32020-1-git-send-email-ian.campbell@xxxxxxxxxx> <20110209162136.GA6160@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Wed, 2011-02-09 at 16:21 +0000, Konrad Rzeszutek Wilk wrote: 
> On Wed, Feb 09, 2011 at 11:10:44AM +0000, Ian Campbell wrote:
> > This workaround was somewhat useful prior to the introduction of the
> > core irq allocator and 026c9d2d0d75 "xen: events: allocate GSIs and
> > dynamic IRQs from separate IRQ ranges." but should not be unnecessary now.
> > 
> > If nr_irqs turns out to be too small under Xen then we use (or define
> > if necessary) the interfaces to increase nr_irqs rather than working
> > around the core allocator in this way.
> > 
> > In my configuration NR_IRQS ends up being 2304 with nr_irq_gsi 272
> > which is sufficient.
> 
> Is this configuration where you run Xen + Linux under QEMU?

No, it was my physical test box.

If this change causes problems under qemu then we need to work with the
x86 guys to find a way to allow us to increase nr_irqs at start of day
when running under Xen (e.g. a generic interface to add headroom for
dynamic IRQs etc).

Ian.

> > 
> > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> > Cc: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
> > ---
> >  drivers/xen/events.c |    7 -------
> >  1 files changed, 0 insertions(+), 7 deletions(-)
> > 
> > diff --git a/drivers/xen/events.c b/drivers/xen/events.c
> > index 975e90f..ce33061 100644
> > --- a/drivers/xen/events.c
> > +++ b/drivers/xen/events.c
> > @@ -393,15 +393,8 @@ static int xen_allocate_irq_dynamic(void)
> >             first = get_nr_irqs_gsi();
> >  #endif
> >  
> > -retry:
> >     irq = irq_alloc_desc_from(first, -1);
> >  
> > -   if (irq == -ENOMEM && first > NR_IRQS_LEGACY) {
> > -           printk(KERN_ERR "Out of dynamic IRQ space and eating into GSI 
> > space. You should increase nr_irqs\n");
> > -           first = max(NR_IRQS_LEGACY, first - NR_IRQS_LEGACY);
> > -           goto retry;
> > -   }
> > -
> >     if (irq < 0)
> >             panic("No available IRQ to bind to: increase nr_irqs!\n");
> >  
> > -- 
> > 1.5.6.5



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel