| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
RE: [Xen-devel] [PATCH]x86:x2apic: Disable x2apic on x86-32 permanently
|
To: |
Jan Beulich <JBeulich@xxxxxxxxxx>, "Zhang, Fengzhe" <fengzhe.zhang@xxxxxxxxx> |
|
Subject: |
RE: [Xen-devel] [PATCH]x86:x2apic: Disable x2apic on x86-32 permanently |
|
From: |
"Wei, Gang" <gang.wei@xxxxxxxxx> |
|
Date: |
Wed, 9 Feb 2011 17:14:38 +0800 |
|
Accept-language: |
zh-CN, en-US |
|
Acceptlanguage: |
zh-CN, en-US |
|
Cc: |
"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, KeirFraser <keir@xxxxxxx>, "Wei, Gang" <gang.wei@xxxxxxxxx> |
|
Delivery-date: |
Wed, 09 Feb 2011 01:15:35 -0800 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<4D5265480200007800030FBA@xxxxxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<1A42CE6F5F474C41B63392A5F80372B231F18B24@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4D4695F0020000780002F6AC@xxxxxxxxxxxxxxxxxx> <F26D193E20BBDC42A43B611D1BDEDE712591710282@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4D5258340200007800030EC9@xxxxxxxxxxxxxxxxxx> <F26D193E20BBDC42A43B611D1BDEDE71259171034F@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4D5265480200007800030FBA@xxxxxxxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
Thread-index: |
AcvIN3eJC1RroW2bQPK3Q1AqicwiKAAAS60g |
|
Thread-topic: |
[Xen-devel] [PATCH]x86:x2apic: Disable x2apic on x86-32 permanently |
Jan Beulich wrote on 2011-02-09:
>>>> On 09.02.11 at 09:43, "Wei, Gang" <gang.wei@xxxxxxxxx> wrote:
>> Jan Beulich wrote on 2011-02-09:
>>>>>> On 09.02.11 at 07:57, "Wei, Gang" <gang.wei@xxxxxxxxx> wrote:
>>>> Jan Beulich wrote on 2011-01-31:
>>>>> How does this (namely the x2apic_enabled part) play together with
>>>>> the selection of the APIC driver, which in this case would have
>>>>> happened quite a bit earlier (from generic_apic_probe())?
>>>>>
>>>>> I would therefore think that this change really belongs into
>>>>> check_x2apic_preenabled().
>>>>
>>>> It is really a problem. But I do think we shall simply remove
>>>> below line from check_x2apic_preenabled() fn:
>>>>
>>>> genapic = apic_x2apic_probe(); The same line exists in
>>>> x2apic_bsp_setup() fn.
>>>
>>> No, that would be exactly the wrong way round - we need genapic to
>>> be set early in case x2apic was pre-enabled (see -unstable c/s 22707).
>>
>> I could not get the reason to set genapic as x2apic in case x2apic
>> was pre-enabled while referring to c/s 22707. Genapic->xxx was never
>> called before calling x2apic_bsp_setup(). Are you trying to keep
>> consistence (x2apic pre-enabled, so genapic have to be x2apic as
>> early as
> possible)?
>
> Without setting genapic here, generic_apic_probe() would set it to
> &apic_default, which is obviously wrong (even if it later gets
> overridden) - just look at the various APIC driver related messages
> that can result on such a system (if you're trying to analyze a
> problem, seeing the APIC driver change perhaps multiple time in the log is
> certainly not helpful).
>
> Apart from that - what problem do you see with just moving the change
> you did into check_x2apic_preenabled()? We're using below patch on
> 4.0.x as replacement/extension to your -unstable c/s 22789 (i.e. a
> patch against current -unstable would need to revert some of what your change
> did).
I just want to make it simple. Both your reason and patch are nice. So could
you please send a formal patch for 4.1?
Jimmy
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home