 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [xen-devel][PATCH 3/5] xl disk configuration parsing changes
| To: | Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [xen-devel][PATCH 3/5] xl disk configuration parsing changes |
| From: | Kamala Narasimhan <kamala.narasimhan@xxxxxxxxx> |
| Date: | Tue, 08 Feb 2011 14:08:52 -0500 |
| Cc: | "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
| Delivery-date: | Tue, 08 Feb 2011 11:09:27 -0800 |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=uHzFp7cjhUkh5UN6dz+wGPR76aCIlvEH1GJgDHNXmUA=; b=delVJkgwOlBscGqYMcWzawyc7QiYaOG2SQEArlHbQIUuyCGz5WYr22PIy9yJMCEWGj 2yD6Uc/QS3GdRyZNm1HB/2AbLGI58maGH6VijueFlyvqAkE/nHKn2QCorx2Cj9iRbJfF pvi9o1YWMz8+gmlk7o4H0pKrbq3WMWBKmeJeo= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=v5swvUiiLuTLMrKq8ZsJZd5OIuCctAgEw646q3G+UKW1+2YN2GelT7Ebjr39kEBLn4 rT+ySNoU+gu/X70+SQHGCvHvEXIgbqTSV3M/mqafZdz2TwalJYlcySbRZpcqmanLdeq8 IMDBzEE9874AohS8MLkoyW14Pj96K8f9ist7w= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <alpine.DEB.2.00.1102081552330.7277@kaball-desktop> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <4D506309.7010803@xxxxxxxxx> <alpine.DEB.2.00.1102081552330.7277@kaball-desktop> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| User-agent: | Thunderbird 2.0.0.24 (X11/20101027) |
>> -#define DSTATE_INITIAL 0
>> -#define DSTATE_TAP 1
>> -#define DSTATE_PHYSPATH 2
>> -#define DSTATE_VIRTPATH 3
>> -#define DSTATE_VIRTTYPE 4
>> -#define DSTATE_RW 5
>> -#define DSTATE_TERMINAL 6
>> +#define DSTATE_INITIAL 0
>> +#define DSTATE_ATTRIB_PARSED 1
>> +#define DSTATE_VDEV_PARSED 2
>
> Why did you need to remove 4 states?
I didn't have a need for it.
> Also it would be nice to split this patch in two: a patch that
> introduces parse_disk_attrib, parse_disk_vdev_info, etc, and a second
> patch that makes any necessary changes to the state machine.
> Otherwise it is very difficult to understand the reason behind each
> change to the state machine.
>
That might be a little tricky. I will talk to you on this offline.
>> static int parse_disk_config(libxl_device_disk *disk, char *buf2)
>> {
>
> There doesn't seem to be a way to set DISK_FORMAT_EMPTY anymore, in fact
> a config line like ',hdc:cdrom,w' seems to be broken.
>
Patch 5/5, validation code should take care of it.
Kamala
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [xen-devel][PATCH 2/5] Xl interface change plus changes to code it impacts, Stefano Stabellini |
|---|---|
| Next by Date: | [Xen-devel] Q on shared_mem and event_channel, ravi kerur |
| Previous by Thread: | Re: [xen-devel][PATCH 3/5] xl disk configuration parsing changes, Stefano Stabellini |
| Next by Thread: | [xen-devel][PATCH 4/5] xl block-attach refactoring to reuse xl parsing code, Kamala Narasimhan |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
