Re: [Xen-devel] [PATCH] vscsi and symlinks

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2011-02-07 at 01:24 +0000, James Harper wrote:
> By default, vscsi expects to be passed the final device name (eg
> /dev/st3) instead of one of the various udev symlinks (eg
> /dev/tape/by-path/pci-0000:01:08.0-scsi-0:0:2:0-st). The following patch
> resolves the path to the real path if the name starts with /dev/

This needs a signed-off-by.

> James
> 
> --- a/tools/python/xen/util/vscsi_util.py  2010-12-03 23:26:46.391655087
> +1100
> +++ b/tools/python/xen/util/vscsi_util.py  2011-02-07 12:20:37.599527204
> +1100
> @@ -158,6 +158,8 @@
> 
> 
>  def vscsi_get_hctl_and_devname_by(target, scsi_devices = None):
> +    if target.startswith('/dev/'):
> +        target = os.path.realpath(target)

Any reason not to just unconditionally resolve symlinks in every target
to the underlying device?

Thanks,
Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel