WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] PCI passthrough issue

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] PCI passthrough issue
From: Jean Baptiste Favre <xen-devel@xxxxxxxxxxx>
Date: Fri, 04 Feb 2011 09:54:30 +0100
Delivery-date: Fri, 04 Feb 2011 00:55:07 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1296809586.13091.546.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4D47F9CF.2040107@xxxxxxxxxxx> <1296566401.13091.171.camel@xxxxxxxxxxxxxxxxxxxxxx> <4D4814CE.5050303@xxxxxxxxxxx> <1296569931.13091.194.camel@xxxxxxxxxxxxxxxxxxxxxx> <4D48234F.2020907@xxxxxxxxxxx> <4D4828D9.6090601@xxxxxxxxxxx> <1296577389.13091.288.camel@xxxxxxxxxxxxxxxxxxxxxx> <4D488355.8010706@xxxxxxxxxxx> <1296638873.13091.315.camel@xxxxxxxxxxxxxxxxxxxxxx> <4D4930F3.608@xxxxxxxxxxx> <20110202174250.GA8148@xxxxxxxxxxxx> <4D4BBC15.4080201@xxxxxxxxxxx> <1296809586.13091.546.camel@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.9.2.13) Gecko/20101207 Lightning/1.0b2 Thunderbird/3.1.7
Hello,

Le 04/02/2011 09:53, Ian Campbell a écrit :
> On Fri, 2011-02-04 at 08:43 +0000, Jean Baptiste Favre wrote:
> 
>> >From Konrad:
>> diff --git a/drivers/net/sky2.c b/drivers/net/sky2.c
>> index 7d85a38..37c0631 100644
>> --- a/drivers/net/sky2.c
>> +++ b/drivers/net/sky2.c
>> @@ -2331,7 +2331,7 @@ static struct sk_buff *receive_copy(struct
>> sky2_port *sky2,
>>      if (likely(skb)) {
>>              pci_dma_sync_single_for_cpu(sky2->hw->pdev, re->data_addr,
>>                                          length, PCI_DMA_FROMDEVICE);
>> -            skb_copy_from_linear_data(re->skb, skb->data, length);
>> +            skb_copy_from_linear_data(skb, re->skb->data, length);
>>              skb->ip_summed = re->skb->ip_summed;
>>              skb->csum = re->skb->csum;
>>              pci_dma_sync_single_for_device(sky2->hw->pdev, re->data_addr,
> 
> Please don't apply this bit, the argument order to skb_copy.... can be a
> bit surprising if you assume it it is like memcpy. The original code is
> correct. This is probably where your L2 issue came from.
> 
> Please can you try again with the just the WARN patch.
Sure I can :)
Did not understood Konrad's patch was incorrect, sorry.

Regards,
JB

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>