WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Three small patches for xen-4.1.0-rc

To: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Subject: Re: [Xen-devel] Three small patches for xen-4.1.0-rc
From: M A Young <m.a.young@xxxxxxxxxxxx>
Date: Tue, 1 Feb 2011 18:29:53 +0000 (GMT)
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 01 Feb 2011 10:32:53 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1296552004.13091.11.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <alpine.LFD.2.02.1101312213190.25216@xxxxxxxxxxxxxxx> <1296552004.13091.11.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.02 (LFD 1266 2009-07-14)
On Tue, 1 Feb 2011, Ian Campbell wrote:

On Mon, 2011-01-31 at 22:37 +0000, M A Young wrote:
The first patch fixes an anomaly in /etc/xen/scripts/network-route.
Currently this script contains
netdev=${netdev:-eth${vifnum}}
ie. netdev is set to eth${vifnum} by default. Unfortunately vifnum is not
set anywhere in the xen code so the default is actually the broken "eth".
The patch changes the default to eth0 (which is what the comment at the
top of the file says it should be).

The comment also refers to an antispoof setting which I don't see being
implemented here. Is that just a wrong comment? (possibly cut and paste
error from one of the other network-*)

I think it is wrong (or maybe there was an intention to implement it which never happened. Only the network-bridge has any antispoofing code.


The next patch updates a comment about NetworkManager not supporting
bridging in Fedora 11 to refer instead to Fedora 14.

Was the NetworkManager stuff introduced in 14 and erroneously documented
as being in 11, or was it in 11 and worked fine, or has it been
continuously broken since F11? IOW should this comment refer to breakage
in Fedora 11 thru 14 or something similar?

I think it has never worked. Fedora is perhaps mentioned because I think it may have been the first distribution to use NetworkManager. So perhaps the reference to Fedora could be removed altogether or by a more general phrase like "such as in Fedora" .

        Michael Young

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>