This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH][SVM] Fix 32bit Windows guest VMs save/restore

To: Keir Fraser <keir@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH][SVM] Fix 32bit Windows guest VMs save/restore
From: Wei Huang <wei.huang2@xxxxxxx>
Date: Mon, 31 Jan 2011 15:43:10 -0600
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "james.harper@xxxxxxxxxxxxxxxx" <james.harper@xxxxxxxxxxxxxxxx>
Delivery-date: Mon, 31 Jan 2011 13:45:20 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C96CE57D.165CF%keir@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C96CE57D.165CF%keir@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv: Gecko/20101207 Thunderbird/3.1.7
This is true. I thought about it. Some problematic code path can be "enter 32bit mode => execute sysenter => turn on long mode" (or vice versa). In this case, SYSENTER MSRs should be copied from VMCB to vcpu fields. But current Xen doesn't do so.


On 01/31/2011 03:17 PM, Keir Fraser wrote:
  suspect the current approach has
further bugs because I don't believe the canonical sysenter msr values are
correctly shuffled between the vmcb and vcpu structures

Xen-devel mailing list