This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [Qemu-devel] [PATCH V9 10/16] xen: Introduce the Xen map

To: Anthony Liguori <anthony@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [Qemu-devel] [PATCH V9 10/16] xen: Introduce the Xen mapcache
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Mon, 31 Jan 2011 16:30:52 +0000
Cc: Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>, Jun, QEMU-devel <qemu-devel@xxxxxxxxxx>, Nakajima <jun.nakajima@xxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>
Delivery-date: Mon, 31 Jan 2011 08:30:03 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D40A946.2020903@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1295965760-31508-1-git-send-email-anthony.perard@xxxxxxxxxx> <1295965760-31508-11-git-send-email-anthony.perard@xxxxxxxxxx> <4D40A946.2020903@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Wed, 26 Jan 2011, Anthony Liguori wrote:
> > +void qemu_invalidate_map_cache(void)
> > +{
> > +    unsigned long i;
> > +    MapCacheRev *reventry;
> > +
> > +    qemu_aio_flush();
> >
> This is bizarre?  Why is this needed?

Sorry, I forgot to reply to this question.

Xen might send an IOREQ_TYPE_INVALIDATE at any time and we have to
flush the mapcache in response.  Of course we cannot flush the mapcache
if there are any in flight AIO's, so we have to make sure they are all
completed before destroying all the mappings.

Maybe there is better API to do that than calling qemu_aio_flush()?

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>