This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] FLR support in xl tool stack

To: Jean Guyader <jean.guyader@xxxxxxxxx>, "Kay, Allen M" <allen.m.kay@xxxxxxxxx>
Subject: RE: [Xen-devel] FLR support in xl tool stack
From: Ross Philipson <Ross.Philipson@xxxxxxxxxx>
Date: Fri, 28 Jan 2011 11:10:47 -0500
Accept-language: en-US
Acceptlanguage: en-US
Cc: Thomas, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>, Wilk <konrad.wilk@xxxxxxxxxx>, Jean Guyader <Jean.Guyader@xxxxxxxxxx>, Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>, Horsten <thomas.horsten@xxxxxxxxxx>
Delivery-date: Fri, 28 Jan 2011 08:11:37 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <AANLkTikW-Rub9WtYCW7k2P1mDFZ=L3tUoFHPL9-JukQQ@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <987664A83D2D224EAE907B061CE93D53019438F9F8@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <AANLkTikW-Rub9WtYCW7k2P1mDFZ=L3tUoFHPL9-JukQQ@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acu+oq/aqNOxRkcOR+SU25tvgvRDgQAYxxdQ
Thread-topic: [Xen-devel] FLR support in xl tool stack
Yeah when I first implemented this in pciback is was looking for a common place 
since the existing FLR logic was in the xend tool-stack (which we were not 
using). Also folks on xen-devel had suggested it go in pciback at the time.

I am not familiar with what reset functionality is in pci in newer kernels 
(there was not a lot in the .27 one) but a lot of what I put in pciback was 
specific to resetting the Intel graphics device on GM45 and Q45 chipsets.


-----Original Message-----
From: Jean Guyader [mailto:jean.guyader@xxxxxxxxx] 
Sent: Thursday, January 27, 2011 11:20 PM
To: Kay, Allen M
Cc: xen-devel; Wilk; Stefano Stabellini; Jean Guyader; Ian Campbell; Thomas 
Horsten; Ross Philipson
Subject: Re: [Xen-devel] FLR support in xl tool stack

On 28 January 2011 08:38, Kay, Allen M <allen.m.kay@xxxxxxxxx> wrote:
> In xm tool stack, there is a function called do_FLR() located in 
> python/xen/util/pci.py that takes care of issuing FLR to passthrough PCI 
> devices.  This function is responsible for looking at the device and figure 
> out the most appropriate way to reset the device (PCI/PCIe FLR, secondary bus 
> reset, etc...).
> In xl tool stack, I see there is a libxl_device_pci_reset() in 
> libxl/libxl_pci.c that suppose to do the similar thing.  It references 
> /sys/bus/pci/drivers/pciback/do_flr and tries to write something to it. 
>  However, pciback driver in pvops kernel does not seem to have this 
> do_flr functionality.
> Is this something being worked on but not checked in to pvops dom0 kernel yet?
> If not, I would prefer implementing all of the do_FLR() functionaility in 
> libxl and not to depend on pciback driver given it is not part of the 
> upstream kernel.  This will make using newer kernels such as 2.6.38 much 
> easier.
> Comments?

On the newest kernels (I don't know from which version), the reset function has 
been moved under the pci device tree directly. So 


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>