This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] libxc: lzma build fix

Ian Campbell writes ("Re: [Xen-devel] [PATCH] libxc: lzma build fix"):
> The physmem value calculated by this function is only used as an
> argument to lzma_alone_decoder, it is divided by 3 to get the memory
> limit for the decoder.

I hadn't spotted that.  I should have looked more closely.

> It's not clear to me why a userspace lzma decode would want to use that
> particular value, what bearing it has on anything or why it would assume
> it could use 1/3 of the total RAM in the system (potentially quite a
> large amount of RAM) as opposed to any other limit number.

It's dom0's "physmem", so not the whole system, but yes.

> Why not just hardcode 32M or something? A quick scan through the
> rdepends on Debian shows at least a couple of users doing so.

Yes, we could revert this patch and hardcode a value.  32M seems


Xen-devel mailing list