This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Seg fault running xl create with 4.1.0-rc2

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] Seg fault running xl create with 4.1.0-rc2
From: M A Young <m.a.young@xxxxxxxxxxxx>
Date: Thu, 27 Jan 2011 20:37:05 +0000 (GMT)
Cc: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Delivery-date: Thu, 27 Jan 2011 12:38:20 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.02 (LFD 1266 2009-07-14)
If I run xl create configfile where configfile includes the lines
bootloader = "/usr/bin/pygrub"
disk = [ 'file:/dev/mapper/vg0-partname,xvda1,w' ]

then xl segfaults at the line
    ret = strdup(dev);

of libxl_device_disk_local_attach() in tools/libxl/libxl.c . The problem is that dev is not set if libxl__blktap_enabled(&gc) is false or if phystype isn't recognized. In the latter case I presume we want to skip that line and return NULL, but if libxl__blktap_enabled(&gc) is false we should be returning something, at least in the case where phystype=PHYSTYPE_FILE, so that we can fall back to qdisk. I think something like the attached patch (not yet tested) should work.

        Michael Young

Attachment: bootloaderfixes.patch
Description: Text document

Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>