This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH 0/6] libxl, xl: fix domain name uniqueness check

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH 0/6] libxl, xl: fix domain name uniqueness check
From: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Date: Thu, 27 Jan 2011 17:40:58 +0000
Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Delivery-date: Thu, 27 Jan 2011 09:41:45 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
We knew that checking for the domain name uniqueness in
parse_config_data in xl was wrong.  Sadly not only is it wrong, but it
doesn't work properly because it prevents the parsing of domain config
files in various other contextx.

Instead, in this series, we put this check in libxl_domain_rename,
which is the right place for it to be.  This function is indeed called
during domain creation to set the domain's name at the start.  As a
sop to those who think domain names are not important, we allow any
number of domains with the name "".  This is not recommended.

However, after moving this check down into the bowels of libxl domain
creation, it became obvious during testing that the error paths with
are taken when the check fails didn't work properly and generated a
lot of noisy output.

So in this series:
  patch 1:     revert the original broken check
  patches 2-5: error path fixes
  patch 6:     add the check to libxl_domain_rename

Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Xen-devel mailing list