Re: [Xen-devel] [PATCH 2/2] hvm: allow pass-through of new CPUID

To:	Andre Przywara <andre.przywara@xxxxxxx>
Subject:	Re: [Xen-devel] [PATCH 2/2] hvm: allow pass-through of new CPUID features
From:	Keir Fraser <keir@xxxxxxx>
Date:	Thu, 27 Jan 2011 16:07:32 +0000
Cc:	xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date:	Thu, 27 Jan 2011 08:08:57 -0800
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:user-agent:date:subject:from:to:cc :message-id:thread-topic:thread-index:in-reply-to:mime-version :content-type:content-transfer-encoding; bh=DVI/xL+RJ0CihtvtiyK8DlbOEfEmfgtA4Ss5L0+sbGs=; b=GAa1XXecDay5+xFZhf55e0R9LXO2ReVmdTpV0sk/X/+SnQDNhZNL535IHvwt45YLd2 kWUbr1W6npfUmo1pNgrZElXMxo9UgfX4Iwbj4MRwNoWX7HBXv439t6SAUSbRC4nojJw8 TqZTZDJ6O9zp66on5XMlXqfNT8f68YwWdBQN0=
Domainkey-signature:	a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=ErmKGFkPqQBYfyI578l12FIjQ1QGroFUH9VqOIl3uHOlfloq3LlLtnlFm7jJMrERxT 16HAhPXbFcmV5WGG7pdwmPiOYfImKObSi7ao2u+ddFz/9SqeDQdnYZ3kA0l5YVHi2OUw Ex7kkIKS+B4+bPIkrSuJ7S33lWrKZYYDbSLXQ=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<4D419294.6010806@xxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	Acu+PE2ikmLl5t1eEk6DL8sYdd7o2w==
Thread-topic:	[Xen-devel] [PATCH 2/2] hvm: allow pass-through of new CPUID features
User-agent:	Microsoft-Entourage/12.28.0.101117

On 27/01/2011 15:43, "Andre Przywara" <andre.przywara@xxxxxxx> wrote:

> Ian Jackson wrote:
>> Stefano Stabellini writes ("Re: [Xen-devel] [PATCH 2/2] hvm: allow
>> pass-through of new CPUID features"):
>>> I think Ian was just looking for a well written explanation of why we
>>> need this now :)
> OK, I feel challenged, what about this:
> 
> The new CPU features are pure "compute" features (ALU/FPU only), they
> don't need any support or awareness from any system level software.
> Following the definition of virtualization they should be available to
> guests unless explicitly disabled.
> The AES feature was introduced at the same time as the PCLMULQDQ
> feature, AES is passed through, PCLMULQDQ has obviously been forgotten(?).
> The Linux kernel uses both instructions in newer versions for optimized
> cryptographic algorithms implementation
> (arch/x86/crypto/ghash-clmulni-intel_asm.S)
> The current version of the Xen hypervisor would deny this feature to any
> PV domains, including Dom0, leaving systems running under Xen with an
> inferior cryptographic performance.
> This patch allows PV domains to use the feature to get on par with
> systems running with other virtualization software.

You've lost your mind a bit there. The patch affects only HVM guests. PV
guests have a feature blacklist policy, and so these features are already
passed through to PV guests (inc. dom0) just fine.

 -- Keir

> Regards,
> Andre.
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH 2/2] hvm: allow pass-through of new CPUID feature