This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] xl: Perform minimal validation of virtual disk f

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xl: Perform minimal validation of virtual disk file while parsing config file
From: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Date: Wed, 26 Jan 2011 11:54:16 +0000
Cc: Kamala Narasimhan <kamala.narasimhan@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Wed, 26 Jan 2011 03:54:51 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19776.2549.115717.510631@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <AANLkTimSUym0u+SNm0AvNp3AZQQFspetAaXmNShkPJd4@xxxxxxxxxxxxxx> <1294995912.8240.86.camel@xxxxxxxxxxxxxxxxxxxxxx> <AANLkTikfUHHc+-gVkgnRJc722wObLF3TumpK5WSfJVAE@xxxxxxxxxxxxxx> <1295024348.12018.222.camel@xxxxxxxxxxxxxxxxxxxxxx> <AANLkTikf3TVJwE_N-OyuS-UhyA8+cgzAG__9hz3AETeM@xxxxxxxxxxxxxx> <AANLkTinJ=PYsC6vbPvU8g2T8NmyohLa=4rd9zfhTMCCO@xxxxxxxxxxxxxx> <AANLkTin1AGxH26158mn37_Oar1PgSSJoJOnGHs+XnxsV@xxxxxxxxxxxxxx> <19768.22912.878633.622270@xxxxxxxxxxxxxxxxxxxxxxxx> <AANLkTinnrmAxaOVu1fN2qt4N2t-EzpF31sKE-Jpn-y2f@xxxxxxxxxxxxxx> <AANLkTi=1b+amdCA4A3AKxAnR6C65xv2+O3BNbGsp-T7i@xxxxxxxxxxxxxx> <19769.31094.274199.464586@xxxxxxxxxxxxxxxxxxxxxxxx> <1295616468.12018.352.camel@xxxxxxxxxxxxxxxxxxxxxx> <4D3A4203.2050706@xxxxxxxxx> <19775.4623.927492.247420@xxxxxxxxxxxxxxxxxxxxxxxx> <1296037654.14780.6743.camel@xxxxxxxxxxxxxxxxxxxxxx> <19776.2549.115717.510631@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Wed, 2011-01-26 at 11:48 +0000, Ian Jackson wrote:
> Ian Campbell writes ("Re: [Xen-devel] [PATCH] xl: Perform minimal validation 
> of virtual disk file while parsing config file"):
> > With this patch applied I get an error using an LVM device via file://
> > (which is currently necessary on upstream dom0 support in order to
> > activate the qdisk support):
> Hrm.  I think the toolstack should really not depend on the user to
> write "file:" some of the time and "phy:" the rest of the time
> according to arcane rules.
> But it's probably too late to fix this properly for 4.1.  In 4.2 xl
> should parse "phy:" and "file:" to PHYSTYPE_PLAIN or something and
> then libxl decide for itself what to do based on backend we are going
> to use and whether the object is a block device.

I think the original rationale for the need to do this was the lack of a
good way to tell if blkback is available on the current host. phy://
becomes blkback whereas file:// becomes blktap whose absence we detect
and fallback to qdisk.

I agree that we should try and do better for 4.2 though.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>