This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] libxl: fix guest networking

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] libxl: fix guest networking
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Mon, 17 Jan 2011 17:25:46 +0000
Cc: Christoph Egger <Christoph.Egger@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 17 Jan 2011 09:26:33 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19764.31358.957714.709713@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <201101121555.03215.Christoph.Egger@xxxxxxx> <19764.31358.957714.709713@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Mon, 2011-01-17 at 17:21 +0000, Ian Jackson wrote:
> +static const char *libxl_tapif_script(libxl__gc *gc)
> +{
> +#ifdef __linux__
> +    return libxl__strdup(gc, "no");
> +#else
> +    return libxl__sprintf(gc, "%s/qemu-ifup", libxl_xen_script_dir_path());
> +#endif
> +}
> I'm really not a fan of #ifdefs in the main parts of the code.
> Perhaps we can (in 4.2) create a file where we can dump these kind of
> things.

IMHO it would be better to switch netbsd to the new model for 4.2.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>