Re: [Xen-devel] [PATCH] libxl: fix guest networking

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2011-01-17 at 17:21 +0000, Ian Jackson wrote:
> +static const char *libxl_tapif_script(libxl__gc *gc)
> +{
> +#ifdef __linux__
> +    return libxl__strdup(gc, "no");
> +#else
> +    return libxl__sprintf(gc, "%s/qemu-ifup", libxl_xen_script_dir_path());
> +#endif
> +}
> 
> I'm really not a fan of #ifdefs in the main parts of the code.
> Perhaps we can (in 4.2) create a file where we can dump these kind of
> things.

IMHO it would be better to switch netbsd to the new model for 4.2.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel