WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH 1/2] xen-unstable/blkif: Move read/write/barrier

To: Keir Fraser <keir@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH 1/2] xen-unstable/blkif: Move read/write/barrier specific fields into a union
From: Owen Smith <owen.smith@xxxxxxxxxx>
Date: Mon, 17 Jan 2011 17:04:56 +0000
Accept-language: en-US
Acceptlanguage: en-US
Cc:
Delivery-date: Mon, 17 Jan 2011 09:06:05 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C95632D8.11D77%keir@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1295023467-27129-3-git-send-email-owen.smith@xxxxxxxxxx> <C95632D8.11D77%keir@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acu0DT4fgzEev7fgOUKo0G0DVQByxgCWWlCQ
Thread-topic: [Xen-devel] [PATCH 1/2] xen-unstable/blkif: Move read/write/barrier specific fields into a union
Attached is a patch that does not require any union of existing structures.

>From the previous patch series,
[PATCH 1/2] xen-unstable/blkif: is obsolete 
[PATCH 2/2] xen-unstable/blkif: is replaced by the attached patch.

The attached version 2 patch only adds definitions to the public header as 
suggested.


> -----Original Message-----
> From: Keir Fraser [mailto:keir.xen@xxxxxxxxx] On Behalf Of Keir Fraser
> Sent: 14 January 2011 17:05
> To: Owen Smith; xen-devel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Xen-devel] [PATCH 1/2] xen-unstable/blkif: Move
> read/write/barrier specific fields into a union
> 
> Redefining the blkif_req struct naming seems an unnecessary pain. Why
> not
> define a separate 'struct blkif_trim_request' that starts with the
> uint8_t
> BLKIF_OP_TRIM and thereafter is defined exactly how you like? Then
> drivers
> can cast a request pointer to your new type when reading/writing a trim
> request, and no existing code needs to be changed. If all this does is
> introduce new definitions into xen-unstable, rather than changing
> existing
> ones, we could still potentially slip it in for 4.1.0 as an obviously
> safe
> patch.
> 
>  -- Keir
> 
> On 14/01/2011 16:44, "owen.smith@xxxxxxxxxx" <owen.smith@xxxxxxxxxx>
> wrote:
> 
> > From: Owen Smith <owen.smith@xxxxxxxxxx>
> >
> > # HG
> > changeset patch
> > # User root@xxxxxxxxxxxxxxxxxxxxxxx
> > # Date 1294919321 0
> > # Node ID 428420495fd3cfda164e7b355b0ffcc0845af2e4
> > # Parent  7b4c82f07281ad9c48b652e2a305a7be607c5283
> > blkif: Move read/write/barrier specific fields into a union
> >
> > Patches xen-unstable.hg
> >
> > Modifies the blkif ring interface by placing the request specific
> > fields into a union in order to support additional operation types.
> >
> > Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@xxxxxxxxxxxxxxxxxxx
> > http://lists.xensource.com/xen-devel
> 

Attachment: xen-unstable-addtrim-v2.patch
Description: xen-unstable-addtrim-v2.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel