This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH] hotplug: allow hardlinked files for block device

To: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] hotplug: allow hardlinked files for block device images
From: Olaf Hering <olaf@xxxxxxxxx>
Date: Mon, 17 Jan 2011 16:57:12 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Mon, 17 Jan 2011 08:01:14 -0800
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1295279849; l=432; s=domk; d=aepfle.de; h=In-Reply-To:Content-Type:MIME-Version:References:Subject:Cc:To:From: Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=SBI9legcdkvJVNRpg0PHUEummdE=; b=lCBmd/Dbr707G+XXpPe8ckJdAgtOdYfHOc8Ubg8DZeD3NZQ9cR2koQeV6PwxqgiqsXL KrMjMBLfulDrfv1JpmG0EQTp4zUBro3Nop4VspFjRxf2iWlC/3agloOIwYje8rPzCTiXc 0VQZHWADoOze6fH0QdRNGa8HiOmQnV7TSqw=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D3464B3.4050200@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20101126135555.GA27483@xxxxxxxxx> <4D3464B3.4050200@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-06-14)
On Mon, Jan 17, Paolo Bonzini wrote:

> Isn't this incorrect in case ${file} contains a character that is a
> regex escape (e.g. a star or backslash)?

I'm sure there are pathnames which break the regex in some way.
Adding an escape for '@' could be added, for example.

How well can the rest of Xen cope with odd filenames? In other words,
does it even get there if the configured pathnames have odd chars in it?


Xen-devel mailing list