This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] RE: Avoid alloc for xsave before xsave_init

To: Keir Fraser <keir@xxxxxxx>, "Huang2, Wei" <Wei.Huang2@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] RE: Avoid alloc for xsave before xsave_init
From: "Wei, Gang" <gang.wei@xxxxxxxxx>
Date: Sun, 16 Jan 2011 23:23:53 +0800
Accept-language: zh-CN, en-US
Acceptlanguage: zh-CN, en-US
Cc: "Wei, Gang" <gang.wei@xxxxxxxxx>
Delivery-date: Sun, 16 Jan 2011 07:26:03 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C955DA80.11D32%keir@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <F26D193E20BBDC42A43B611D1BDEDE7125198A86DA@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <C955DA80.11D32%keir@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcuzUojLeS2z6tQSQCO88b+hMX2tAQAC+pjAAAIkzIwAEIzTQAAD8xugAAfj98gAbi0uEA==
Thread-topic: Avoid alloc for xsave before xsave_init
Keir Fraser wrote on 2011-01-14:
> On 14/01/2011 07:11, "Wei, Gang" <gang.wei@xxxxxxxxx> wrote:
>>> I agree that do test-and-exit on is_idle_vcpu() in
>>> Xsave_{alloc,free}_save_area.
>>> Further, We'd better add assert(xsave_cntxt_size>=576) after the
>>> test-and-exit clause to ensure no buffer overflow will happen in the future.
>>> I reviewed the context switch code and assure context switch code
>>> not be doing XSAVE when switching out an idle vcpu.
>> Here is the patch.
> I applied your patch, plus some cleanup, as of c/s 22751.

Your cleanup looks good.


Xen-devel mailing list