This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] RE: [PATCH] mem_sharing: fix race condition of nominate and

To: xen devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] RE: [PATCH] mem_sharing: fix race condition of nominate and unshare
From: MaoXiaoyun <tinnycloud@xxxxxxxxxxx>
Date: Fri, 14 Jan 2011 10:04:35 +0800
Cc: tim.deegan@xxxxxxxxxx, juihaochiang@xxxxxxxxx
Delivery-date: Thu, 13 Jan 2011 18:06:29 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
Importance: Normal
In-reply-to: <20110113155344.GN5651@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <BLU157-ds1E01DEBE18840E5FBB6D1DA0E0@xxxxxxx>, <AANLkTikBaB5awvRu3Sn3WfuoS3LRmeBH=pG8c7H1n4Cw@xxxxxxxxxxxxxx>, <AANLkTinoXve=zBzB9qN1qXRz+iJmhiQ+-gB7MwFoY5Dg@xxxxxxxxxxxxxx>, <20110112105405.GH5651@xxxxxxxxxxxxxxxxxxxxxxx>, <BLU157-w59C63325262D0BE99E6C43DAF10@xxxxxxx>, <20110112140223.GI5651@xxxxxxxxxxxxxxxxxxxxxxx>, <BLU157-w1861EFE53CB51FC710011FDAF10@xxxxxxx>, <AANLkTimOz_uauDEnu_XaPEgwD1EZJWEgOO1oiFccFNs1@xxxxxxxxxxxxxx>, <20110113092427.GJ5651@xxxxxxxxxxxxxxxxxxxxxxx>, <AANLkTinSga8xDkuH0BsqbhbBtvgwgbn=T0qmg9y9CeGr@xxxxxxxxxxxxxx>, <20110113155344.GN5651@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi Tim:
     Thanks for the patch, xen panic on more stressed test. ( 12HVMS, each of them reboot every 30minutes).
     Please refer to below log.
blktap_sysfs_create: adding attributes for dev ffff8801044bc400
blktap_sysfs_create: adding attributes for dev ffff8801044bc200
__ratelimit: 4 callbacks suppressed
(XEN) Xen BUG at mem_sharing.c:454
(XEN) ----[ Xen-4.0.0  x86_64  debug=n  Not tainted ]----
(XEN) CPU:    0
(XEN) RIP:    e008:[<ffff82c4801bf52c>] mem_sharing_gfn_account+0x5c/0x70
(XEN) RFLAGS: 0000000000010246   CONTEXT: hypervisor
(XEN) rax: 0000000000000000   rbx: 0000000000000001   rcx: 0000000000000000
(XEN) rdx: 0000000000000000   rsi: 000000000000005f   rdi: 000000000000005f
(XEN) rbp: ffff8305894f0fc0   rsp: ffff82c48035fc48   r8:  ffff82f600000000
(XEN) r9:  00007fffcdbd0fb8   r10: ffff82c4801f8c70   r11: 0000000000000282
(XEN) r12: ffff82c48035fe28   r13: ffff8303192a3bf0   r14: ffff82f60b966700
(XEN) r15: 0000000000000006   cr0: 0000000080050033   cr4: 00000000000026f0
(XEN) cr3: 000000032ea58000   cr2: ffff880119c2e668
(XEN) ds: 0000   es: 0000   fs: 0000   gs: 0000   ss: e010   cs: e008
(XEN) Xen stack trace from rsp=ffff82c48035fc48:
(XEN)    00000000fffffff7 ffff82c4801bf8c0 0000000000553b86 ffff8305894f0fc0
(XEN)    ffff8302f4d12cf0 0000000000553b86 ffff82f603e28580 ffff82c48035fe38
(XEN)    ffff83023fe60000 ffff82c48035fe28 0000000000305000 0000000000000006
(XEN)    0000000000000006 ffff82c4801c0724 ffff82c4801447da 0000000000553b86
(XEN)    000000000001a938 00000000006ee000 00000000006ee000 ffff82c4801457fd
(XEN)    0000000000000096 0000000000000001 ffff82c48035fd30 0000000000000080
(XEN)    ffff82c480376980 ffff82c480251080 0000000000000292 ffff82 c48011c519
(XEN)    ffff82c48035fe28 0000000000000080 0000000000000000 ffff8302ef312fa0
(XEN)    ffff8300b4aee000 ffff82c48025f080 ffff82c480251080 ffff82c480118351
(XEN)    0000000000000080 0000000000000000 ffff8300b4aef708 00000de9e9529c40
(XEN)    ffff8300b4aee000 0000000000000292 ffff8305cf9f09b8 0000000000000001
(XEN)    0000000000000001 0000000000000000 00000000002159e6 fffffffffffffff3
(XEN)    00000000006ee000 ffff82c48035fe28 0000000000305000 0000000000000006
(XEN)    0000000000000006 ffff82c480104373 ffff8305cf9f09c0 ffff82c4801a0b63
(XEN)    00000000159e6070 ffff8305cf9f0000 0000000000000007 ffff83023fe60180
(XEN)    0000000600000039 0000000000000000 00007fae14b30003 000000000054fdad
(XEN)    0000000000553b86 ffffffffff600429 000000004d2f26e8 0000000000088742
(XEN)    00 00000000000000 00007fae14b30070 00007fae14b30000 00007fffcdbd0f50
(XEN)    00007fae14b30078 0000000000430e98 00007fffcdbd0fb8 0000000000cd39c8
(XEN)    0005aeb700000007 00007fae15bd2ab0 0000000000000000 0000000000000246
(XEN) Xen call trace:
(XEN)    [<ffff82c4801bf52c>] mem_sharing_gfn_account+0x5c/0x70
(XEN)    [<ffff82c4801bf8c0>] mem_sharing_share_pages+0x170/0x310
(XEN)    [<ffff82c4801c0724>] mem_sharing_domctl+0xe4/0x130
(XEN)    [<ffff82c4801447da>] __find_next_bit+0x6a/0x70
(XEN)    [<ffff82c4801457fd>] arch_do_domctl+0xdad/0x1f90
(XEN)    [<ffff82c48011c519>] cpumask_raise_softirq+0x89/0xa0
(XEN)    [<ffff82c480118351>] csched_vcpu_wake+0x101/0x1b0
(XEN)    [<ffff82c480104373>] do_domctl+0x163/0x1000
(XEN)    [<ffff82c 4801a0b63>] hvm_set_callback_irq_level+0xe3/0x110
(XEN)    [<ffff82c4801e3169>] syscall_enter+0xa9/0xae
(XEN) ****************************************
(XEN) Panic on CPU 0:
(XEN) Xen BUG at mem_sharing.c:454
(XEN) ****************************************
(XEN) Manual reset required ('noreboot' specified)

> Date: Thu, 13 Jan 2011 15:53:44 +0000
> From: Tim.Deegan@xxxxxxxxxx
> To: juihaochiang@xxxxxxxxx
> CC: tinnycloud@xxxxxxxxxxx; xen-devel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH] mem_sharing: fix race condition of nominate and unshare
> At 15:24 +0000 on 13 Jan (1294932299), Jui-Hao Chiang wrote:
> > After testing the code with your patch, it's ok for the mem_sharing.
> > And as the argument says, when (type_count & PGT_count_mask) is zero,
> > it's ok for changing the page type. (even when there is a old value in
> > type_count & PGT_type_mask, e.g., ti=8400000000000000)
> Great, thanks. I've applied that change as cset 22745:32b7a4f2d399
> of xen-unstable and the EPT locking fix as 22744:b01ef59c8c80 .
> They're in the staging tree and will hit the public tree the next time
> the automatic regression tests pass.
> Cheers,
> Tim.
> --
> Tim Deegan <Tim.Deegan@xxxxxxxxxx>
> Principal Software Engineer, Xen Platform Team
> Citrix Systems UK Ltd. (Company #02937203, SL9 0BG)
Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>