This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 2/7] xen-gntdev: Change page limit to be global i

To: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 2/7] xen-gntdev: Change page limit to be global instead of per-open
From: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
Date: Tue, 11 Jan 2011 13:18:09 -0500
Cc: jeremy@xxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, Ian.Campbell@xxxxxxxxxx
Delivery-date: Tue, 11 Jan 2011 10:19:33 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20110111175146.GG14017@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: National Security Agency
References: <1292545063-32107-1-git-send-email-dgdegra@xxxxxxxxxxxxx> <1292545063-32107-3-git-send-email-dgdegra@xxxxxxxxxxxxx> <20110110215245.GD15016@xxxxxxxxxxxx> <4D2C50EE.8010200@xxxxxxxxxxxxx> <20110111175146.GG14017@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc13 Thunderbird/3.1.7
On 01/11/2011 12:51 PM, Konrad Rzeszutek Wilk wrote:
> On Tue, Jan 11, 2011 at 07:45:34AM -0500, Daniel De Graaf wrote:
>> On 01/10/2011 04:52 PM, Konrad Rzeszutek Wilk wrote:
>>>>  static long gntdev_ioctl(struct file *flip,
>>>>                     unsigned int cmd, unsigned long arg)
>>>>  {
>>>> @@ -555,9 +538,6 @@ static long gntdev_ioctl(struct file *flip,
>>>>            return gntdev_ioctl_get_offset_for_vaddr(priv, ptr);
>>>> -          return gntdev_ioctl_set_max_grants(priv, ptr);
>>> Would it make sense to return -EPNOTSUPPORTED? Or does it not really
>>> matter as nobody has been using this ioctl call?
>> Does this produce a clearer error message than the default -ENOIOCTLCMD?
>> It's possible that some people use it, since it was exposed as an API.
> Looking at the Xen tools the user of this is:
> xc_gnttab_set_max_grants which would end up returning whatever the
> error is. I don't see any users of this in the Xen tools, thought there might
> be some in the XCP code. Lets stay with your ENOIOCTLCMD.
> However, I was wondering if you are going to submit a patch to the Xen
> tool stack so that it can utlize the SysFS interface to set the limits
> for that API call?

No, because the semantics of what the limit is covering have changed. The
new limit is per-domain, and if there was any existing code that set the
limit, it would have been a per-open value and probably too low. I think
it was suggested that the call be removed from the Xen API; I can submit
a patch to do that, if you want.

The new value is probably best set in modprobe.conf if gntdev is a module;
the sysfs interface is useful for runtime adjustment or if it is builtin.

Daniel De Graaf
National Security Agency

Xen-devel mailing list