This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] libxc: build fixes

To: Olaf Hering <olaf@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] libxc: build fixes
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Tue, 11 Jan 2011 12:46:09 +0000
Cc: Christoph Egger <Christoph.Egger@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Delivery-date: Tue, 11 Jan 2011 04:48:27 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20110111104132.GA2982@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <201101061646.53565.Christoph.Egger@xxxxxxx> <19749.64362.58747.605990@xxxxxxxxxxxxxxxxxxxxxxxx> <20110111104132.GA2982@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Tue, 2011-01-11 at 10:41 +0000, Olaf Hering wrote:
> On Thu, Jan 06, Ian Jackson wrote:
> > Christoph Egger writes ("[Xen-devel] [PATCH] libxc: build fixes"):
> > > Attached patch makes libxc build again on NetBSD after the recent rework.
> > 
> > I have applied this.  However:
> > 
> > I changed the name of the new make variable from LIBDL to DLOPEN_LIBS.
> > The latter conforms to the naming scheme for similar variables found
> > in config/*.mk - PTHREAD_LIBS et al.
> > 
> > Also I moved the setting of the variable to -dl from Linux to StdGNU
> > (which makes it apply more widely) and also added it to SunOS.mk
> > (based on pure guesswork).
> This is incomplete. flask does not build because linking fails with
> missing dlopen/dlsym etc. This change fixes it for me.

I thought there was a way to convince ld to do this sort of thing
automatically without forcing higher layers to know all about the
transitive dependencies.

However we've got a bunch of this stuff already and I don't think anyone
really wants to go messing with the build system so close to the 4.1-rc0
anyway so:

> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>


> --- xen-unstable.hg-4.1.22697.orig/tools/Rules.mk
> +++ xen-unstable.hg-4.1.22697/tools/Rules.mk
> @@ -18,7 +18,7 @@ XEN_BLKTAP2        = $(XEN_ROOT)/tools/b
>  CFLAGS_include = -I$(XEN_INCLUDE)
>  CFLAGS_libxenctrl = -I$(XEN_LIBXC) $(CFLAGS_include)
> -LDLIBS_libxenctrl = -L$(XEN_LIBXC) -lxenctrl
> +LDLIBS_libxenctrl = -L$(XEN_LIBXC) -lxenctrl $(DLOPEN_LIBS)
>  CFLAGS_libxenguest = -I$(XEN_LIBXC) $(CFLAGS_include)
>  LDLIBS_libxenguest = -L$(XEN_LIBXC) -lxenguest
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

Xen-devel mailing list