Re: [Xen-devel] [PATCH 5/7] xen-gntdev: Add reference counting to maps

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

> -static void gntdev_free_map(struct grant_map *map)
> -{
> -     unsigned i;
> +     atomic_sub(map->count, &pages_mapped);
>  
> -     if (!map)
> -             return;
> +     if (!use_ptemod)
> +             unmap_grant_pages(map, 0, map->count);
>  
>       for (i = 0; i < map->count; i++) {
>               if (map->pages[i])
>                       __free_page(map->pages[i]);
>       }
> +     kfree(map->pages);

Can you roll that in the previous patch that introduced the map->pages code?

>       kfree(map);
>  }
>  
> @@ -310,6 +305,7 @@ static void gntdev_vma_close(struct vm_area_struct *vma)
>       map->is_mapped = 0;
>       map->vma = NULL;
>       vma->vm_private_data = NULL;
> +     gntdev_put_map(map);

I am somehow not seeing this function, nor the use_ptemod defined. Ah, you 
answered
that later on..

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel