WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] fix "Error flushing ioemu cache" message in xenp

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] fix "Error flushing ioemu cache" message in xenpaging
From: Olaf Hering <olaf@xxxxxxxxx>
Date: Mon, 10 Jan 2011 11:29:39 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Han-Lin Li <astercase@xxxxxxxxx>
Delivery-date: Mon, 10 Jan 2011 02:30:21 -0800
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1294655380; l=1708; s=domk; d=aepfle.de; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version: References:Subject:Cc:To:From:Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=SWyuNAJ3h+ej73R9mMGkBm5zIlE=; b=mlV3skEq7qOeiEwW0HqXMyjuQkrF1mOV/sPz0m+OOHc3B1TcdfUrYSNfCDW2iYXAIIG 6XUYqw2VIjEw7/v5HbaPQyCL66jVLVebKdrQaYlOkj9uR2DENeJMSIqA66DXIsdpiZqL0 e9yItgYHIyyQg/k19/XaYlGxkIqnOUN16QU=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19749.65323.879474.273431@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <AANLkTi=o_pDNBoW1-qDZ_jtWOhmeWgJqBoqhDCUz371e@xxxxxxxxxxxxxx> <19749.65323.879474.273431@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-06-14)
On Thu, Jan 06, Ian Jackson wrote:

> Han-Lin Li writes ("[Xen-devel] [PATCH] fix "Error flushing ioemu cache" 
> message in xenpaging"):
> > While using xenpaging, "Error flushing ioemu cache" message will be shown
> > on screen even if the "flush-cache" command is sent to xenstore correctly.
> > That is because xenpaging assume xc_mem_paging_flush_ioemu_cache()
> > return non-zero value when operation fail.  But
> > xc_mem_paging_flush_ioemu_cache() return the return value from xs_write()
> > which is zero when operation fail. So,  we should invert the return value 
> > from
> > xs_write() before use it as return value to prevent printing those
> > incorrect error messages.
> 
> I'd like to give Olaf Hering a chance to respond, though, as it seems
> he hasn't already.

I see these harmless error messages as well, but havent looked at the
root cause yet.

> Perhaps xc_mem_paging_flush_ioemu_cache ought to return -1 on error
> and 0 on success, like most other xc functions ?

Like 'return rc ? 0 : -1;'?
Either way is fine with me.

Olaf

> > ---
> > Signed-off-by: Han-Lin Li <Han-Lin.Li@xxxxxxxxxxx>
> > 
> > diff -r 89116f28083f tools/xenpaging/xc.c
> > --- a/tools/xenpaging/xc.c      Wed Dec 08 10:46:31 2010 +0000
> > +++ b/tools/xenpaging/xc.c      Wed Dec 15 19:23:53 2010 +0800
> > @@ -62,7 +62,7 @@
> >      xs_daemon_close(xsh);
> > -    return rc;
> > +    return !rc;
> >  }
> >  int xc_wait_for_event_or_timeout(xc_interface *xch, int xce_handle,
> > unsigned long ms)
> > 
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@xxxxxxxxxxxxxxxxxxx
> > http://lists.xensource.com/xen-devel
> > 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>