This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH] x86-64: refine access permission check for wrmsr to

To: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] x86-64: refine access permission check for wrmsr to MSR_FAM10H_MMIO_CONF_BASE
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Mon, 10 Jan 2011 09:18:13 +0000
Delivery-date: Mon, 10 Jan 2011 01:19:11 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
We really don't want the mmconf window to move/disappear whenever we
use is ourselves, not only when we enabled it.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

--- a/xen/arch/x86/traps.c
+++ b/xen/arch/x86/traps.c
@@ -2297,8 +2297,7 @@ static int emulate_privileged_op(struct 
                 goto fail;
             if (
 #ifdef CONFIG_X86_64
-                 (pci_probe & PCI_PROBE_MMCONF) &&
-                 (pci_probe & PCI_CHECK_ENABLE_AMD_MMCONF) ?
+                 (pci_probe & PCI_PROBE_MASK) == PCI_PROBE_MMCONF ?
                  val != msr_content :
                  ((val ^ msr_content) &

Attachment: x86_64-fam10-mmconf-wrmsr-2.patch
Description: Text document

Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] x86-64: refine access permission check for wrmsr to MSR_FAM10H_MMIO_CONF_BASE, Jan Beulich <=