This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH]: minios: eliminate compile warning - use of unin

To: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH]: minios: eliminate compile warning - use of uninitialised variable
From: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>
Date: Fri, 7 Jan 2011 17:42:22 +0000
Cc: Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Fri, 07 Jan 2011 09:43:43 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1294420919.12018.89.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1294419169.12018.79.camel@xxxxxxxxxxxxxxxxxxxxxx> <20110107165822.GX5820@xxxxxxxxxxxxxxxxxxxxxxx> <1294420919.12018.89.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, 2011-01-07 at 17:21 +0000, Gianni Tedesco wrote:
> On Fri, 2011-01-07 at 16:58 +0000, Samuel Thibault wrote:
> > Gianni Tedesco, le Fri 07 Jan 2011 16:52:49 +0000, a écrit :
> > > I'm not sure if this is a legit catch by gcc or a false positive due to
> > > extra cleverness in gcc-4.5. Either way it causes the build to barf.
> > 
> > It seems a false positive to me. What is the warning message?

Actually looks like these are incorrect when compiled 64bit and not
needed anyway. Following patch does the job.

diff -r 4695fd70077d extras/mini-os/lib/math.c
--- a/extras/mini-os/lib/math.c Fri Jan 07 17:13:53 2011 +0000
+++ b/extras/mini-os/lib/math.c Fri Jan 07 17:40:20 2011 +0000
@@ -59,9 +59,9 @@
 #include <mini-os/lib.h>
 #include <mini-os/time.h>
-       /* On ia64 these functions lead to crashes. These are replaced by
+       /* These functions are incorrect on 64bit. On ia64 they are replaced by
         * assembler functions. */
-#if !defined(__ia64__)
+#if !defined(__ia64__) && !defined(__x86_64__)
  * Depending on the desired operation, we view a `long long' (aka quad_t) in

Xen-devel mailing list