This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 2 of 4] xl: Introduce libxl_domain_create_new() a

On Thu, 2011-01-06 at 19:34 +0000, Stefano Stabellini wrote:
> On Thu, 6 Jan 2011, Ian Jackson wrote:
> > Gianni Tedesco writes ("[Xen-devel] [PATCH 2 of 4] xl: Introduce 
> > libxl_domain_create_new() and libxl_domain_create_restore()"):
> > > xl: Introduce libxl_domain_create_new() and libxl_domain_create_restore()
> > 
> > This patch looks reasonable to me - at least, the API seems sensible
> > to me.  I didn't diff all of the shuffled-about code :-).
> > 
> > I'll wait for an ack from Stefano too though.
> Thanks.
> I think the patch is overall correct but please make sure to test it
> with stubdoms at least once.

OK, I'll do a thorough round of testing before submitting next version.
I may have found an error in there anyway but I need to chase that one
down to be sure.

> Also I think we need to move all the init_*_info functions to libxl too,
> in order to provide sensible defaults for libxl_domain_config *d_config.

Yeah, I just realised that last night. To be honest there's a lot of
duplicated fields in those structures so that they may be better off
being re-organised somehow anyway. I'll see what I can come up with.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>